[stl_interfaces] Ok to merge small fix to C++20-mode builds before release?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[stl_interfaces] Ok to merge small fix to C++20-mode builds before release?

Boost - Dev mailing list
I have just committed a fix to develop that addresses compilation
errors in C++20 builds.   Is it too late to merge this to master?  The
change is here:

https://github.com/boostorg/stl_interfaces/commit/6d31433af0b7cb8c7f9140ce408ec70468552fa0

Zach

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [stl_interfaces] Ok to merge small fix to C++20-mode builds before release?

Boost - Dev mailing list
On Jul 9, 2020, at 2:58 PM, Zach Laine via Boost <[hidden email]> wrote:
>
> I have just committed a fix to develop that addresses compilation
> errors in C++20 builds.   Is it too late to merge this to master?  The
> change is here:
>
> https://github.com/boostorg/stl_interfaces/commit/6d31433af0b7cb8c7f9140ce408ec70468552fa0

Zach -

That doesn’t really look like a “small fix” to me.

I’m not going to tell you you CANT merge it to master, but I would feel better if you let the build bots cycle first.
But then it will probably be too late for the beta.
If that’s what happens, I have no problem with you merging it post-beta.

— Marshall (who really dislikes turning an R2/R3/R4)


_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [stl_interfaces] Ok to merge small fix to C++20-mode builds before release?

Boost - Dev mailing list
On Thu, Jul 9, 2020 at 5:41 PM Marshall Clow <[hidden email]> wrote:

>
> On Jul 9, 2020, at 2:58 PM, Zach Laine via Boost <[hidden email]> wrote:
> >
> > I have just committed a fix to develop that addresses compilation
> > errors in C++20 builds.   Is it too late to merge this to master?  The
> > change is here:
> >
> > https://github.com/boostorg/stl_interfaces/commit/6d31433af0b7cb8c7f9140ce408ec70468552fa0
>
> Zach -
>
> That doesn’t really look like a “small fix” to me.
>
> I’m not going to tell you you CANT merge it to master, but I would feel better if you let the build bots cycle first.
> But then it will probably be too late for the beta.
> If that’s what happens, I have no problem with you merging it post-beta.

Ok, I'm glad I asked.  I'll wait, and merge on the 15th or so, after
the beta.  Thanks, Marshall!

Zach

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost