[review][JSON] Ruthgers' review

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[review][JSON] Ruthgers' review

Boost - Dev mailing list
> Do you think the library should be accepted as a Boost library?
It will be a good addition to Boost if this library gets ACCEPTed
> What is your evaluation of the design?
It works, is straightforward and the interface feels good to use, the
only pitfall is getting the right type you want; number_cast took me a
second to realize it existed and the custom string class is something
the will most likely be converted alot to std::string in an average
users' code.
> What is your evaluation of the implementation?
As a casual user I cannot comment on this, but as I used it in stand
alone / header only mode without problem I feel that i should be
alright under the hood
> What is your evaluation of the documentation?
Could be better, especially in the examples department; it could use
how-to basics
> What is your evaluation of the potential usefulness of the library?
Very useful
> Did you try to use the library? With what compiler? Did you have any
> problems?
I have implemented it in a real project where RapidJSON was used before.
No real problems found aside from getting exceptions because
.as_double() is not able to get a technically integer from the json
(which happens in user configs, example: { "test": 20 }) but that
quickly resolved itself with number_cast,
Ideally any number should be able to become a double in my opinion.
Clang 10.0.1 was used.
> How much effort did you put into your evaluation? A glance? A quick
> reading? In-depth study?
As stated above implemented in one project which took about an hour.
> Are you knowledgeable about the problem domain?
No, this review is coming from a pure casual user

kindly, Ruthger Dijt


_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [review][JSON] Ruthgers' review

Boost - Dev mailing list
On Tue, Sep 22, 2020 at 2:35 PM Ruthger Dijt via Boost
<[hidden email]> wrote:
> It will be a good addition to Boost if this library gets ACCEPTed

Thank you for taking the time to review the library, and I am glad you
found it useful for you!

Regards

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost