Quantcast

[integer] Please fix build/test errors..

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[integer] Please fix build/test errors..

Boost - Dev mailing list
The Integer library is causing general CI failures: <
https://travis-ci.org/boostorg/boost/jobs/230199520#L6396>

Please rectify ASAP.

--
-- Rene Rivera
-- Grafik - Don't Assume Anything
-- Robot Dreams - http://robot-dreams.net
-- rrivera/acm.org (msn) - grafikrobot/aim,yahoo,skype,efnet,gmail

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [integer] Please fix build/test errors..

Boost - Dev mailing list
John..

You have until EOD today, 11:59pm CDT, to fix this. It's causing *all*
testing to to stall. Otherwise I'll be forced to change it myself. And I
would really like to avoid doing that.

On Mon, May 8, 2017 at 11:54 PM, Rene Rivera <[hidden email]> wrote:

> The Integer library is causing general CI failures: <
> https://travis-ci.org/boostorg/boost/jobs/230199520#L6396>
>
> Please rectify ASAP.
>



--
-- Rene Rivera
-- Grafik - Don't Assume Anything
-- Robot Dreams - http://robot-dreams.net
-- rrivera/acm.org (msn) - grafikrobot/aim,yahoo,skype,efnet,gmail

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [integer] Please fix build/test errors..

Boost - Dev mailing list
Rene Rivera wrote:
> John..
>
> You have until EOD today, 11:59pm CDT, to fix this. It's causing *all*
> testing to to stall.

Could this be a opportunity to bring up the idea (again) of testing
libraries one by one (foreach $lib do b2 libs/$lib/test) instead of using a
single Jamfile?


_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [integer] Please fix build/test errors..

Boost - Dev mailing list
In reply to this post by Boost - Dev mailing list
Hi Rene,

Am Dienstag, 9. Mai 2017, 17:01:31 CEST schrieb Rene Rivera via Boost:
> John..
>
> You have until EOD today, 11:59pm CDT, to fix this. It's causing *all*
> testing to to stall. Otherwise I'll be forced to change it myself. And I
> would really like to avoid doing that.

Well, the fix is really simple. Please find the patch attached.
Applying trivial patches does not seem that much of an issue to me.

Yours,

Jürgen
--
* Dipl.-Math. Jürgen Hunold  !
* voice: ++49 4257 300       ! Fährstraße 1
* fax  : ++49 4257 300       ! 31609 Balge/Sebbenhausen
* [hidden email]             ! Germany

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

gmpcxx.diff (582 bytes) Download Attachment
signature.asc (201 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [integer] Please fix build/test errors..

Boost - Dev mailing list
On Tue, May 9, 2017 at 11:08 AM, Jürgen Hunold <[hidden email]> wrote:

> Hi Rene,
>
> Am Dienstag, 9. Mai 2017, 17:01:31 CEST schrieb Rene Rivera via Boost:
> > John..
> >
> > You have until EOD today, 11:59pm CDT, to fix this. It's causing *all*
> > testing to to stall. Otherwise I'll be forced to change it myself. And I
> > would really like to avoid doing that.
>
> Well, the fix is really simple. Please find the patch attached.
>

Please PR it.


> Applying trivial patches does not seem that much of an issue to me.
>

I prefer as much as possible to not muck in an author's "space". The
triviality of the fix is not the issue.

--
-- Rene Rivera
-- Grafik - Don't Assume Anything
-- Robot Dreams - http://robot-dreams.net
-- rrivera/acm.org (msn) - grafikrobot/aim,yahoo,skype,efnet,gmail

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [integer] Please fix build/test errors..

Boost - Dev mailing list
In reply to this post by Boost - Dev mailing list

>> You have until EOD today, 11:59pm CDT, to fix this. It's causing *all*
>> testing to to stall. Otherwise I'll be forced to change it myself. And I
>> would really like to avoid doing that.

I can't apologise enough, stupid mistake!

> Well, the fix is really simple. Please find the patch attached.
> Applying trivial patches does not seem that much of an issue to me.

Thank you Jurgen, that is indeed the fix, now pushed to develop.

John.

>
> Yours,
>
> Jürgen
>
>
> _______________________________________________
> Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost


---
This email has been checked for viruses by AVG.
http://www.avg.com


_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [integer] Please fix build/test errors..

Boost - Dev mailing list
John Maddock wrote:

> I can't apologise enough, stupid mistake!

You should pay attention to the Travis e-mails :-)

https://travis-ci.org/boostorg/integer/builds/229655938

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [integer] Please fix build/test errors..

Boost - Dev mailing list


On 09/05/2017 18:06, Peter Dimov via Boost wrote:
> John Maddock wrote:
>
>> I can't apologise enough, stupid mistake!
>
> You should pay attention to the Travis e-mails :-)

I've never had an email from Travis - isn't it supposed to send one to
the committer automatically?

John.

>
> https://travis-ci.org/boostorg/integer/builds/229655938
>
> _______________________________________________
> Unsubscribe & other changes:
> http://lists.boost.org/mailman/listinfo.cgi/boost
>


---
This email has been checked for viruses by AVG.
http://www.avg.com


_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [integer] Please fix build/test errors..

Boost - Dev mailing list
John Maddock wrote:

> I've never had an email from Travis - isn't it supposed to send one to the
> committer automatically?

Yes, it should (and it does for me). Maybe you have a spam filter.


_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Loading...