fixed_string: Request for review

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

fixed_string: Request for review

Boost - Dev mailing list
Hi all,

My name Is Krystian Stasiowski. I'm currently attending college as a
Computer Science major, am active on the C++ Language Slack, and starting
to contribute to ISO C++. Vinnie offered for me to take the lead on
submitting Boost.FixedString for a formal review, so here I am!

Applicable links:
Github: https://github.com/18
Repo: https://github.com/18/fixed_string
Docs: https://18.github.io/doc/fixed_string

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: fixed_string: Request for review

Boost - Dev mailing list

First:

1)wonderful documentation!

2)
A few ideas

=>

2.1)find_count_of
=>find number of occurences of 'argument'

2.2)get_sequence_of =>return sequence of 'begin'=>'end'

2.3)set_sequence_of => set sequence of 'begin'=>'end' with 'arg'

2.4)set_slice_of => ~= 2.3)

2.5)get_slice_of => ~= 2.2)

6)char_traits<T> here but =>> also for any type/class?
Quoting Krystian Stasiowski via Boost <[hidden email]>:

Good work!

Please regard this as constructive critism,

Ty
G

> Hi a
> ,y


> My name Is Krystian Stasiowski. I'm currently attending college as a
> Computer Science major, am active on the C++ Language Slack, and starting
> to contribute to ISO C++. Vinnie offered for me to take the lead on
> submitting Boost.FixedString for a formal review, so here I am!
>
> Applicable links:
> Github: https://github.com/18
> Repo: https://github.com/18/fixed_string
> Docs: https://18.github.io/doc/fixed_string
>
> _______________________________________________
> Unsubscribe & other changes:  
> http://lists.boost.org/mailman/listinfo.cgi/boost


Tell me, and I forget. Ask me, and I discover...



_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: fixed_string: Request for review

Boost - Dev mailing list
In reply to this post by Boost - Dev mailing list
El 09/11/2019 a las 1:05, Krystian Stasiowski via Boost escribió:

> Hi all,
>
> My name Is Krystian Stasiowski. I'm currently attending college as a
> Computer Science major, am active on the C++ Language Slack, and starting
> to contribute to ISO C++. Vinnie offered for me to take the lead on
> submitting Boost.FixedString for a formal review, so here I am!
>
> Applicable links:
> Github: https://github.com/18
> Repo: https://github.com/18/fixed_string
> Docs: https://18.github.io/doc/fixed_string

Hi,

After conversation on Slack with Krystian and Vinnie, I'm volunteering
to manage the review.
Ron, a timeframe that would work for me is Nov 25 - Dec 1. Does this
also work for you?

Joaquín M López Muñoz

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost