[archive] Patch for BCB2006

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[archive] Patch for BCB2006

Nicola Musatti
Hallo,
this is the same as a patch already applied to
boost/detail/utf8_codecvt_facet.hpp and as one I just submitted for
boost/iostreams/detail/config/codecvt.hpp .

Cheers,
Nicola Musatti

******Index: codecvt_null.hpp
===================================================================
RCS file: /cvsroot/boost/boost/boost/archive/codecvt_null.hpp,v
retrieving revision 1.13
diff -d -u -r1.13 codecvt_null.hpp
--- codecvt_null.hpp 12 Dec 2005 15:22:02 -0000 1.13
+++ codecvt_null.hpp 8 Apr 2006 15:04:18 -0000
@@ -26,7 +26,7 @@
         using ::mbstate_t;
     #elif defined(__QNXNTO__)
         using std::mbstate_t;
-    #elif defined(BOOST_DINKUMWARE_STDLIB)
+    #elif defined(BOOST_DINKUMWARE_STDLIB) && ! defined(__BORLANDC__)
         using ::mbstate_t;
     #elif defined(__SGI_STL_PORT)
     #elif defined(BOOST_NO_STDC_NAMESPACE)

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [archive] Patch for BCB2006

Nicola Musatti
Nicola Musatti wrote:
> Hallo,
> this is the same as a patch already applied to
> boost/detail/utf8_codecvt_facet.hpp and as one I just submitted for
> boost/iostreams/detail/config/codecvt.hpp .

Robert,
you seem to have forgotten to commit this to main line, or was it
intentional?

Cheers,
Nicola Musatti

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [archive] Patch for BCB2006

Robert Ramey
I've put it into RC_1_34_0 for the following reasons:

a) that's the one that's getting tested.
b) if things work as they did last time, these changes will be merged back
into the main trunk when 1.34 is released.  As you can see from
http://engineering.meta-comm.com/boost-regression/CVS-RC_1_34_0/developer/serialization.html
this has helped - but we're still not there yet.

Robert Ramey
Nicola Musatti wrote:

> Nicola Musatti wrote:
>> Hallo,
>> this is the same as a patch already applied to
>> boost/detail/utf8_codecvt_facet.hpp and as one I just submitted for
>> boost/iostreams/detail/config/codecvt.hpp .
>
> Robert,
> you seem to have forgotten to commit this to main line, or was it
> intentional?
>
> Cheers,
> Nicola Musatti
>
> _______________________________________________
> Unsubscribe & other changes:
> http://lists.boost.org/mailman/listinfo.cgi/boost 



_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [archive] Patch for BCB2006

Nicola Musatti
Robert Ramey wrote:

> I've put it into RC_1_34_0 for the following reasons:
>
> a) that's the one that's getting tested.
> b) if things work as they did last time, these changes will be merged back
> into the main trunk when 1.34 is released.  As you can see from
> http://engineering.meta-comm.com/boost-regression/CVS-RC_1_34_0/developer/serialization.html
> this has helped - but we're still not there yet.

I browsed through the test results I get from my patches against 1.33.1.
I see basically two kinds of problems: compile time errors seem to be
mostly related to a Borland bug where top level consts aren't removed in
  argument type deduction. At times I've been able to work around this
problem by explicitly specifying function template arguments. The
runtime problems seem to be mostly related to the pool allocator, but I
don't know what's wrong there exactly. Could it be a naming issue?
calling members 'malloc' and 'free' is really not a good idea :-(
Another issue worth looking into is namespaces and using declarations. I
believe something has changed there too.

Note that bcc 5.8.2 beta fares somewhat better than 5.8.1, but I believe
  that Alisdair Meredith hasn't committed his updated borland.hpp file
yet, which is needed to get the newest compiler to work.

I hope to be able to be more precise tonight.

Cheers,
Nicola Musatti

P.S. Maybe you should put a note in the documentation stating that in
order to use Spirit 1.6 from outside the Boost source tree with Borland
compilers all include directives of boost sources should be changed from
using double quotes to using angle brackets, i.e. from

#include "boost/..."

to

#include <boost/...>

This is reflected in the current SPIRIT_1_6_BRANCH in CVS, but will only
be generally available when Spirit 1.6.4 is released.

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost