Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

Sean Reilly
Background: 

I was looking at Boost 1.57 and noticed that my old 7902 bug was still in there.

Bug #6511 added enable_if<> to file: vector_expression.hpp function: operator/( vector, scalar). The same feature needs to be add to matrix_expression's operator/( matrix, scalar). See attached e-mail
By campreilly@… — 01/17/13 21:55:55

This error is almost exactly the same as a previous bug that has already been fixed in vector_expression.hpp under issue 6511.  But, I forgot to mention matrix_expression.hpp in that bug, perhaps because I'm a knucklehead.  

file: vector_expression.hpp lines 1409 through 1417 function: operator/( vector, scalar) Should be using the enable_if<> macros just like the operator*() in lines 1397 through 1407 (just above it). Doing so allows further overloading ...
By Sean Reilly <campreilly@…> — 02/01/12 15:38:09

Question:

It is a simple one line fix, but I haven't kept up with the updated development and delivery process. Would you like me to fork GitHub, fix it, and issue a pull request.  Is that how we are handling these kinds of changes?

Sean Reilly

_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

David Bellot
Hi Sean,

yes, for any bug fix, please use Github. For the project in your own account and checkout branch develop.
When you submit your pull request, it must be for branch develop.

We're not using the old repository anymore.

Thanks for contributing,
David


On Thu, Nov 20, 2014 at 5:35 PM, Sean Reilly <[hidden email]> wrote:
Background: 

I was looking at Boost 1.57 and noticed that my old 7902 bug was still in there.

Bug #6511 added enable_if<> to file: vector_expression.hpp function: operator/( vector, scalar). The same feature needs to be add to matrix_expression's operator/( matrix, scalar). See attached e-mail
By campreilly@… — 01/17/13 21:55:55

This error is almost exactly the same as a previous bug that has already been fixed in vector_expression.hpp under issue 6511.  But, I forgot to mention matrix_expression.hpp in that bug, perhaps because I'm a knucklehead.  

file: vector_expression.hpp lines 1409 through 1417 function: operator/( vector, scalar) Should be using the enable_if<> macros just like the operator*() in lines 1397 through 1407 (just above it). Doing so allows further overloading ...
By Sean Reilly <campreilly@…> — 02/01/12 15:38:09

Question:

It is a simple one line fix, but I haven't kept up with the updated development and delivery process. Would you like me to fork GitHub, fix it, and issue a pull request.  Is that how we are handling these kinds of changes?

Sean Reilly

_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]


_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

Nasos Iliopoulos
Sean,
please fork from:
https://github.com/uBLAS/ublas/tree/develop

and not from the the boostorg repository.

General guidelines:
https://github.com/uBLAS/ublas/wiki


-Nasos

On 11/20/2014 02:42 PM, David Bellot wrote:
Hi Sean,

yes, for any bug fix, please use Github. For the project in your own account and checkout branch develop.
When you submit your pull request, it must be for branch develop.

We're not using the old repository anymore.

Thanks for contributing,
David


On Thu, Nov 20, 2014 at 5:35 PM, Sean Reilly <[hidden email]> wrote:
Background: 

I was looking at Boost 1.57 and noticed that my old 7902 bug was still in there.

Bug #6511 added enable_if<> to file: vector_expression.hpp function: operator/( vector, scalar). The same feature needs to be add to matrix_expression's operator/( matrix, scalar). See attached e-mail
By campreilly@… — 01/17/13 21:55:55

This error is almost exactly the same as a previous bug that has already been fixed in vector_expression.hpp under issue 6511.  But, I forgot to mention matrix_expression.hpp in that bug, perhaps because I'm a knucklehead.  

file: vector_expression.hpp lines 1409 through 1417 function: operator/( vector, scalar) Should be using the enable_if<> macros just like the operator*() in lines 1397 through 1407 (just above it). Doing so allows further overloading ...
By Sean Reilly <campreilly@…> — 02/01/12 15:38:09

Question:

It is a simple one line fix, but I haven't kept up with the updated development and delivery process. Would you like me to fork GitHub, fix it, and issue a pull request.  Is that how we are handling these kinds of changes?

Sean Reilly

_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]



_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]


_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

Sean Reilly
This is my first time contributing to boost, and I'm having some trouble getting started using the instructions on https://github.com/uBLAS/ublas/wiki.  It appears that boost itself is having a problem with the boostrap process.  Here is all that I'm doing to demonstrate this problem.

    git clone https://github.com/boostorg/boost modular-boost
    cd modular-boost/
    ./bootstrap.sh

Responds with 

    ./bootstrap.sh: line 188: ./tools/build/src/engine/build.sh: No such file or directory

and it turns out that the ./tools/build directory is empty.  As the man says, "Gee that don't look right."

Heard of anyone else having this issue with the boost repository?  Can I get around this my just stealing the contents from the Boost 1.57 distribution?

Sean


On Thu, Nov 20, 2014 at 4:16 PM, Nasos Iliopoulos <[hidden email]> wrote:
Sean,
please fork from:
https://github.com/uBLAS/ublas/tree/develop

and not from the the boostorg repository.

General guidelines:
https://github.com/uBLAS/ublas/wiki


-Nasos


On 11/20/2014 02:42 PM, David Bellot wrote:
Hi Sean,

yes, for any bug fix, please use Github. For the project in your own account and checkout branch develop.
When you submit your pull request, it must be for branch develop.

We're not using the old repository anymore.

Thanks for contributing,
David


On Thu, Nov 20, 2014 at 5:35 PM, Sean Reilly <[hidden email]> wrote:
Background: 

I was looking at Boost 1.57 and noticed that my old 7902 bug was still in there.

Bug #6511 added enable_if<> to file: vector_expression.hpp function: operator/( vector, scalar). The same feature needs to be add to matrix_expression's operator/( matrix, scalar). See attached e-mail
By campreilly@… — 01/17/13 21:55:55

This error is almost exactly the same as a previous bug that has already been fixed in vector_expression.hpp under issue 6511.  But, I forgot to mention matrix_expression.hpp in that bug, perhaps because I'm a knucklehead.  

file: vector_expression.hpp lines 1409 through 1417 function: operator/( vector, scalar) Should be using the enable_if<> macros just like the operator*() in lines 1397 through 1407 (just above it). Doing so allows further overloading ...
By Sean Reilly <campreilly@…> — 02/01/12 15:38:09

Question:

It is a simple one line fix, but I haven't kept up with the updated development and delivery process. Would you like me to fork GitHub, fix it, and issue a pull request.  Is that how we are handling these kinds of changes?

Sean Reilly

_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]



_______________________________________________ ublas mailing list [hidden email] http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]


_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]


_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

Joaquim Duran
The issue with the procedure defined in
https://github.com/uBLAS/ublas/wiki is since version 1.57, modular
boost checkout an specific commit id from boostorg/ublas. That commit
id is not present in ublas/ublas so checkout process fails. This could
be the origin of the problem. This problem has a workarround, I'll
explain it when I comeback at home.

Joaquim Duran


2014-11-23 0:55 GMT+01:00 Sean Reilly <[hidden email]>:

> This is my first time contributing to boost, and I'm having some trouble
> getting started using the instructions on
> https://github.com/uBLAS/ublas/wiki.  It appears that boost itself is having
> a problem with the boostrap process.  Here is all that I'm doing to
> demonstrate this problem.
>
>     git clone https://github.com/boostorg/boost modular-boost
>     cd modular-boost/
>     ./bootstrap.sh
>
> Responds with
>
>     ./bootstrap.sh: line 188: ./tools/build/src/engine/build.sh: No such
> file or directory
>
> and it turns out that the ./tools/build directory is empty.  As the man
> says, "Gee that don't look right."
>
> Heard of anyone else having this issue with the boost repository?  Can I get
> around this my just stealing the contents from the Boost 1.57 distribution?
>
> Sean
>
>
> On Thu, Nov 20, 2014 at 4:16 PM, Nasos Iliopoulos <[hidden email]>
> wrote:
>>
>> Sean,
>> please fork from:
>> https://github.com/uBLAS/ublas/tree/develop
>>
>> and not from the the boostorg repository.
>>
>> General guidelines:
>> https://github.com/uBLAS/ublas/wiki
>>
>>
>> -Nasos
>>
>>
>> On 11/20/2014 02:42 PM, David Bellot wrote:
>>
>> Hi Sean,
>>
>> yes, for any bug fix, please use Github. For the project in your own
>> account and checkout branch develop.
>> When you submit your pull request, it must be for branch develop.
>>
>> We're not using the old repository anymore.
>>
>> Thanks for contributing,
>> David
>>
>>
>> On Thu, Nov 20, 2014 at 5:35 PM, Sean Reilly <[hidden email]> wrote:
>>>
>>> Background:
>>>
>>> I was looking at Boost 1.57 and noticed that my old 7902 bug was still in
>>> there.
>>>
>>> #7902: Bugs: Division by scalar should use enable_if<>
>>> (matrix_expression) (new)
>>> Bug #6511 added enable_if<> to file: vector_expression.hpp function:
>>> operator/( vector, scalar). The same feature needs to be add to
>>> matrix_expression's operator/( matrix, scalar). See attached e-mail By
>>> campreilly@… — 01/17/13 21:55:55
>>>
>>> This error is almost exactly the same as a previous bug that has already
>>> been fixed in vector_expression.hpp under issue 6511.  But, I forgot to
>>> mention matrix_expression.hpp in that bug, perhaps because I'm a
>>> knucklehead.
>>>
>>> #6511: Bugs: Division by scalar should use enable_if<> (closed: fixed)
>>> file: vector_expression.hpp lines 1409 through 1417 function: operator/(
>>> vector, scalar) Should be using the enable_if<> macros just like the
>>> operator*() in lines 1397 through 1407 (just above it). Doing so allows
>>> further overloading ... By Sean Reilly <campreilly@…> — 02/01/12 15:38:09
>>>
>>> Question:
>>>
>>> It is a simple one line fix, but I haven't kept up with the updated
>>> development and delivery process. Would you like me to fork GitHub, fix it,
>>> and issue a pull request.  Is that how we are handling these kinds of
>>> changes?
>>>
>>> Sean Reilly
>>>
>>> _______________________________________________
>>> ublas mailing list
>>> [hidden email]
>>> http://lists.boost.org/mailman/listinfo.cgi/ublas
>>> Sent to: [hidden email]
>>
>>
>>
>>
>> _______________________________________________
>> ublas mailing list
>> [hidden email]
>> http://lists.boost.org/mailman/listinfo.cgi/ublas
>> Sent to: [hidden email]
>>
>>
>>
>> _______________________________________________
>> ublas mailing list
>> [hidden email]
>> http://lists.boost.org/mailman/listinfo.cgi/ublas
>> Sent to: [hidden email]
>
>
>
> _______________________________________________
> ublas mailing list
> [hidden email]
> http://lists.boost.org/mailman/listinfo.cgi/ublas
> Sent to: [hidden email]
_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

Nasos Iliopoulos
Sean,
It should be ok now.

Although boostrap didn't seem to give me any problems, we needed to
fetch from upstream after 1.57 was finalized as Joaquim pointed out. Can
you please try now?

-Nasos

On 11/24/2014 03:36 AM, Joaquim Duran wrote:
> git clonehttps://github.com/boostorg/boost  modular-boost

_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

Sean Reilly
Still having a problem getting the tests to running on CentOS 6.6 with gcc 4.4.7 compiler.

/usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../include/c++/4.4.7/bits/stl_function.h:199: error: ‘template<class _Tp> struct std::equal_to’ is not a function,
common/testhelper.hpp:126: error:   conflict with ‘template<class M1, class M2> bool equal_to(const boost::numeric::ublas::vector_expression<E>&, const boost::numeric::ublas::vector_expression<E2>&, double)’
test_assignment.cpp:30: error:   in call to ‘equal_to’
test_assignment.cpp:601:   instantiated from here

Basically, there seems to be a name conflict between the equal_to() template function defined in testhelper.h

template < class M1, class M2 >
bool equal_to( const boost::numeric::ublas::vector_expression<M1> & m1,
               const boost::numeric::ublas::vector_expression<M2> & m2,
               double tolerance = 0.0 ) {
    if (m1().size() != m2().size()) {
        return false;
    }

    return mean_square(m2() - m1()) <= tolerance;
}

And the equal_to() template function defined in stl_function.h

  template<typename _Tp>
    struct equal_to : public binary_function<_Tp, _Tp, bool>
    {
      bool
      operator()(const _Tp& __x, const _Tp& __y) const
      { return __x == __y; }
    };

Anybody else having this issue?

Sean Reilly

_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

Joaquim Duran
I wrote the function. I executed the tests with g++ 4.8 (Fedora 20)
and I didn't detect any issue.

As work around, you should rename the function equal_to.

To fix the issue, is it really needed have to sets of functions to
compare vectors and matrices? Maybe, we could have just a jest of
functions named 'compare'.

Thanks and Best Regards,
Joaquim Duran


2014-12-09 20:40 GMT+01:00 Sean Reilly <[hidden email]>:

> Still having a problem getting the tests to running on CentOS 6.6 with gcc
> 4.4.7 compiler.
>
> /usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../include/c++/4.4.7/bits/stl_function.h:199:
> error: ‘template<class _Tp> struct std::equal_to’ is not a function,
> common/testhelper.hpp:126: error:   conflict with ‘template<class M1, class
> M2> bool equal_to(const boost::numeric::ublas::vector_expression<E>&, const
> boost::numeric::ublas::vector_expression<E2>&, double)’
> test_assignment.cpp:30: error:   in call to ‘equal_to’
> test_assignment.cpp:601:   instantiated from here
>
>
> Basically, there seems to be a name conflict between the equal_to() template
> function defined in testhelper.h
>
> template < class M1, class M2 >
> bool equal_to( const boost::numeric::ublas::vector_expression<M1> & m1,
>                const boost::numeric::ublas::vector_expression<M2> & m2,
>                double tolerance = 0.0 ) {
>     if (m1().size() != m2().size()) {
>         return false;
>     }
>
>     return mean_square(m2() - m1()) <= tolerance;
> }
>
>
> And the equal_to() template function defined in stl_function.h
>
>   template<typename _Tp>
>     struct equal_to : public binary_function<_Tp, _Tp, bool>
>     {
>       bool
>       operator()(const _Tp& __x, const _Tp& __y) const
>       { return __x == __y; }
>     };
>
>
> Anybody else having this issue?
>
> Sean Reilly
>
> _______________________________________________
> ublas mailing list
> [hidden email]
> http://lists.boost.org/mailman/listinfo.cgi/ublas
> Sent to: [hidden email]
_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

Sean Reilly
I'd be happy to make that change.  Would you like me to bug an issue into the Boost Trac database?

I see from the Wiki that your trying to standardize incoming branch names into something like bugfix/ublas00002_xxxx.  What would you like me to use for "bug number" (ex: 00002)?  Trac issue number?  One bigger than other branches that I see out there?

Sean


_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: Should/can I use GitHub to fix issue #7902 Division by scalar should use enable_if<>

Nasos Iliopoulos
Sean,
for such a small fix just fork from develop (https://github.com/uBLAS/ublas/tree/develop) and push back when you are done. A brief on the point description in the commit message will do. I will accept the pull request as soon as I run the unit tests.



-Nasos



On 12/10/2014 09:06 AM, Sean Reilly wrote:
I'd be happy to make that change.  Would you like me to bug an issue into the Boost Trac database?

I see from the Wiki that your trying to standardize incoming branch names into something like bugfix/ublas00002_xxxx.  What would you like me to use for "bug number" (ex: 00002)?  Trac issue number?  One bigger than other branches that I see out there?

Sean



_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]


_______________________________________________
ublas mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/ublas
Sent to: [hidden email]