Re: [Boost][GIL][GSOC21]Wish to know about code review process

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Boost][GIL][GSOC21]Wish to know about code review process

Boost - Dev mailing list
Hello Everyone,
                         I am a bit new to the world of open source and so
I would like to know how the code review of pull requests is actually done.
I have come to know that when I add a new feature to the library, I have to
submit a test file along with my pull request. After that,what happens is
unknown to me.Understanding this would help me to realize the entire
process from pull requests to merging and therefore increase the quality of
my contribution. I shall be highly thankful to anyone who may take time out
of his/her busy schedule to explain this a bit to me.
                          Thank you all.

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [Boost][GIL][GSOC21]Wish to know about code review process

Boost - Dev mailing list
On Tue, 30 Mar 2021 at 14:50, sayan chaudhuri via Boost
<[hidden email]> wrote:
>
> Hello Everyone,
>                          I am a bit new to the world of open source and so
> I would like to know how the code review of pull requests is actually done.
> I have come to know that when I add a new feature to the library, I have to
> submit a test file along with my pull request.

https://github.com/boostorg/gil/blob/develop/CONTRIBUTING.md#pull-requests

> After that,what happens is unknown to me.

Then, you wait until maintainers have time to review your PR.
We are all volunteers here and there is no way to nudge anyone
with "urgent" message.
The priorities, obviously, change during GSoC and related PRs
are usually reviewed in timely manner.

> Understanding this would help me to realize the entire
> process from pull requests to merging and therefore increase the quality of
> my contribution.

https://opensource.guide/how-to-contribute/
https://github.com/boostorg/gil/blob/develop/CONTRIBUTING.md

Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost