Is there any difference , or is this redundant ?

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Is there any difference , or is this redundant ?

Boost - Build mailing list

Hi I’m looking to update my pull request to ASIO and I’m looking at various NT logic that’s are causing problems for cross-compiles.

 

In various …

libs/asio/example/… /Jamfile.v2

 

else if [ os.name ] = NT

{

  lib ws2_32 ;

  lib mswsock ;

}

 

exe transmit_file

  : transmit_file.cpp

    /boost/system//boost_system

  : <define>BOOST_ALL_NO_LIB=1

    …

    <os>NT:<define>_WIN32_WINNT=0x0501

    <os>NT,<toolset>gcc:<library>ws2_32

    <os>NT,<toolset>gcc:<library>mswsock

    <os>NT,<toolset>gcc-cygwin:<define>__USE_W32_SOCKETS

 

Could we not just ?

 

    <target-os>windows:<library>ws2_32

    <target-os>windows:<library>mswsock

 

Many thanks,

 

Brian Kuhl

Wind River

 


_______________________________________________
Unsubscribe & other changes: https://lists.boost.org/mailman/listinfo.cgi/boost-build
Reply | Threaded
Open this post in threaded view
|

Re: Is there any difference , or is this redundant ?

Boost - Build mailing list
AMDG

On 01/09/2018 02:38 PM, Kuhl, Brian via Boost-build wrote:

> Hi I'm looking to update my pull request to ASIO and I'm looking at various NT logic that's are causing problems for cross-compiles.
> > In various ...
> libs/asio/example/... /Jamfile.v2
>
> else if [ os.name ] = NT
> {
>   lib ws2_32 ;
>   lib mswsock ;
> }
> <snip>
>     <os>NT:<define>_WIN32_WINNT=0x0501
> <snip>
>
> Could we not just ?
>
>     <target-os>windows:<library>ws2_32
>     <target-os>windows:<library>mswsock
>

Yes, <target-os> is the correct way.  <os> has
been obsolete for years.

In Christ,
Steven Watanabe
_______________________________________________
Unsubscribe & other changes: https://lists.boost.org/mailman/listinfo.cgi/boost-build
Reply | Threaded
Open this post in threaded view
|

Re: Is there any difference , or is this redundant ?

Boost - Build mailing list
Hi Steven,
Is there anything special about contributing to the ASIO library, the pull requests don't seem to get much attention?

Thanks,

Brian


> -----Original Message-----
> From: Boost-build [mailto:[hidden email]] On Behalf Of
> Steven Watanabe via Boost-build
> Sent: Tuesday, January 09, 2018 5:05 PM
> To: Kuhl, Brian via Boost-build
> Cc: Steven Watanabe
> Subject: Re: [Boost-build] Is there any difference , or is this redundant ?
>
> AMDG
>
> On 01/09/2018 02:38 PM, Kuhl, Brian via Boost-build wrote:
> > Hi I'm looking to update my pull request to ASIO and I'm looking at various NT
> logic that's are causing problems for cross-compiles.
> > > In various ...
> > libs/asio/example/... /Jamfile.v2
> >
> > else if [ os.name ] = NT
> > {
> >   lib ws2_32 ;
> >   lib mswsock ;
> > }
> > <snip>
> >     <os>NT:<define>_WIN32_WINNT=0x0501
> > <snip>
> >
> > Could we not just ?
> >
> >     <target-os>windows:<library>ws2_32
> >     <target-os>windows:<library>mswsock
> >
>
> Yes, <target-os> is the correct way.  <os> has been obsolete for years.
>
> In Christ,
> Steven Watanabe
> _______________________________________________
> Unsubscribe & other changes:
> https://lists.boost.org/mailman/listinfo.cgi/boost-build
_______________________________________________
Unsubscribe & other changes: https://lists.boost.org/mailman/listinfo.cgi/boost-build
Reply | Threaded
Open this post in threaded view
|

Re: Is there any difference , or is this redundant ?

Boost - Build mailing list
In reply to this post by Boost - Build mailing list
This one was bit more complex, is the alias part correct?

example/cpp03/ssl/Jamfile.v2 | 30 +++++++++++-------------------
 1 file changed, 11 insertions(+), 19 deletions(-)

diff --git a/example/cpp03/ssl/Jamfile.v2 b/example/cpp03/ssl/Jamfile.v2
index 0b3e229..ecbeb64 100644
--- a/example/cpp03/ssl/Jamfile.v2
+++ b/example/cpp03/ssl/Jamfile.v2
@@ -12,11 +12,6 @@ if [ os.name ] = SOLARIS
   lib socket ;
   lib nsl ;
 }
-else if [ os.name ] = NT
-{
-  lib ws2_32 ;
-  lib mswsock ;
-}
 else if [ os.name ] = HPUX
 {
   lib ipv6 ;
@@ -26,16 +21,13 @@ else if [ os.name ] = HAIKU
   lib network ;
 }
 
-if [ os.name ] = NT
-{
-  lib ssl : : <name>ssleay32 ;
-  lib crypto : : <name>libeay32  ;
-}
-else
-{
-  lib ssl ;
-  lib crypto ;
-}
+alias ssl_libs  
+ : <library>ssleay32 <library>libeay32
+ : <target-os>windows
+ ;
+alias ssl_libs : <library>ssl <library>crypto ;
+
+explicit ssl_libs
 
 project
   : requirements
@@ -45,14 +37,14 @@ project
     <os>SOLARIS:<library>socket
     <os>SOLARIS:<library>nsl
     <target-os>windows:<define>_WIN32_WINNT=0x0501
-    <target-os>windows,<toolset>gcc:<library>ws2_32
-    <target-os>windows,<toolset>gcc:<library>mswsock
+    <target-os>windows:<library>ws2_32
+    <target-os>windows:<library>mswsock
+    <target-os>windows:<library>ssleay32
     <target-os>windows,<toolset>gcc-cygwin:<define>__USE_W32_SOCKETS
     <os>HPUX,<toolset>gcc:<define>_XOPEN_SOURCE_EXTENDED
     <os>HPUX:<library>ipv6
     <os>HAIKU:<library>network
-    <library>ssl
-    <library>crypto
+    ssl_libs
   ;
 
 exe client : client.cpp ;


> -----Original Message-----
> From: Boost-build [mailto:[hidden email]] On Behalf Of
> Steven Watanabe via Boost-build
> Sent: Tuesday, January 09, 2018 5:05 PM
> To: Kuhl, Brian via Boost-build
> Cc: Steven Watanabe
> Subject: Re: [Boost-build] Is there any difference , or is this redundant ?
>
> AMDG
>
> On 01/09/2018 02:38 PM, Kuhl, Brian via Boost-build wrote:
> > Hi I'm looking to update my pull request to ASIO and I'm looking at various NT
> logic that's are causing problems for cross-compiles.
> > > In various ...
> > libs/asio/example/... /Jamfile.v2
> >
> > else if [ os.name ] = NT
> > {
> >   lib ws2_32 ;
> >   lib mswsock ;
> > }
> > <snip>
> >     <os>NT:<define>_WIN32_WINNT=0x0501
> > <snip>
> >
> > Could we not just ?
> >
> >     <target-os>windows:<library>ws2_32
> >     <target-os>windows:<library>mswsock
> >
>
> Yes, <target-os> is the correct way.  <os> has
> been obsolete for years.
>
> In Christ,
> Steven Watanabe
> _______________________________________________
> Unsubscribe & other changes:
> https://lists.boost.org/mailman/listinfo.cgi/boost-build
_______________________________________________
Unsubscribe & other changes: https://lists.boost.org/mailman/listinfo.cgi/boost-build
Reply | Threaded
Open this post in threaded view
|

Re: Is there any difference , or is this redundant ?

Boost - Build mailing list
AMDG

On 01/09/2018 10:04 PM, Kuhl, Brian via Boost-build wrote:

> This one was bit more complex, is the alias part correct?
>
> <snip>
> -if [ os.name ] = NT
> -{
> -  lib ssl : : <name>ssleay32 ;
> -  lib crypto : : <name>libeay32  ;
> -}
> -else
> -{
> -  lib ssl ;
> -  lib crypto ;
> -}
> +alias ssl_libs  
> + : <library>ssleay32 <library>libeay32
> + : <target-os>windows
> + ;
> +alias ssl_libs : <library>ssl <library>crypto ;
> +
> +explicit ssl_libs
>  

You can't use <library> without declaring the library as its own target.

try:
lib ssl : : <target-os>windows:<name>ssleay32 ;

In Christ,
Steven Watanabe
_______________________________________________
Unsubscribe & other changes: https://lists.boost.org/mailman/listinfo.cgi/boost-build
Reply | Threaded
Open this post in threaded view
|

Re: Is there any difference , or is this redundant ?

Boost - Build mailing list
Comments appreciated
https://github.com/boostorg/asio/pull/54/commits/ae22a204684170b4fdfd95532a4a679a40268762


> -----Original Message-----
> From: Boost-build [mailto:[hidden email]] On Behalf Of
> Steven Watanabe via Boost-build
> Sent: Wednesday, January 10, 2018 10:34 AM
> To: [hidden email]
> Cc: Steven Watanabe
> Subject: Re: [Boost-build] Is there any difference , or is this redundant ?
>
> AMDG
>
> On 01/09/2018 10:04 PM, Kuhl, Brian via Boost-build wrote:
> > This one was bit more complex, is the alias part correct?
> >
> > <snip>
> > -if [ os.name ] = NT
> > -{
> > -  lib ssl : : <name>ssleay32 ;
> > -  lib crypto : : <name>libeay32  ;
> > -}
> > -else
> > -{
> > -  lib ssl ;
> > -  lib crypto ;
> > -}
> > +alias ssl_libs
> > + : <library>ssleay32 <library>libeay32
> > + : <target-os>windows
> > + ;
> > +alias ssl_libs : <library>ssl <library>crypto ;
> > +
> > +explicit ssl_libs
> >
>
> You can't use <library> without declaring the library as its own target.
>
> try:
> lib ssl : : <target-os>windows:<name>ssleay32 ;
>
> In Christ,
> Steven Watanabe
> _______________________________________________
> Unsubscribe & other changes:
> https://lists.boost.org/mailman/listinfo.cgi/boost-build
_______________________________________________
Unsubscribe & other changes: https://lists.boost.org/mailman/listinfo.cgi/boost-build