Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Submitted By: David Benbennick (dbenbenn)
>Assigned to: Jonathan Turkanis (turkanis)
Summary: rational::operator<(rational) fails due to overflow
Consider boost::rational<long>. Pick two objects of
that type at random (that's well defined, since there
are only finitely many objects of that type), and pick
them to both have the same sign. Call them a and b.
Then the expression "a < b" returns the wrong value 50%
of the time! The problem is that the calculation in
rational.hpp can overflow, and that overflow actually
happens most of the time.
Here's a patch that implements operator< without
overflow. It's somewhat less efficient (I haven't
benchmarked it) but it gives the right answer.
Possibly the new version of operator< has bugs. I've
run a few hundred million random tests, with the right
answer every time (I've used bc to check the answers),
but there might be a subtle problem. In particular,
the new code assumes that integer division always
truncates towards 0, even when dividing negative
integers. Perhaps that is not true on some obscure