[1.47.0] Any remaining showstoppers?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
31 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Daniel James-3
On 7 July 2011 21:33, Beman Dawes <[hidden email]> wrote:
> On Thu, Jul 7, 2011 at 1:03 PM, Emil Dotchevski
> <[hidden email]> wrote:
>
>> The fix is committed to trunk, I'm waiting for it to get through all
>> the tests and then I'll ask for permission to merge in the release
>> branch.
>
> OK, I'll hold the release waiting for that merge.

Does that mean that John's merge is okay as well?
_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Vicente Botet
In reply to this post by Beman Dawes
Beman Dawes wrote
On Wed, Jul 6, 2011 at 9:38 PM, Eric Niebler <[hidden email]> wrote:
> On 7/6/2011 3:57 PM, Vicente Botet wrote:
>>
>> Beman Dawes wrote:
>>>
>>> Any remaining 1.47.0 showstoppers?
>>>
>>> I'm still waiting for an OK to merge
>>> http://svn.boost.org/trac/boost/changeset/72855
>>>
>>> Are there any other merges ready to go that still need permission to
>>> merge?
>>>
>>>
>> Hi,
>>
>> recently Edward found a bug on Boost.Chrono with win/intel compiler:
>> http://boost.2283326.n4.nabble.com/chrono-Intel-Composer-XE-2011-unable-to-compile-chrono-library-tt3647568.html#a3650214
>>
>> I have committed https://svn.boost.org/trac/boost/changeset/72938 on trunk a
>> simple patch. Can I commit after verification on trunk?
>
> Adding an extra set of superfluous parens makes the compiler happy?
> Really? That's whack. <shrug>
>
> Looks totally safe to me, but I don't know if Beman is in the packaging
> phase of the release yet. Beman?

I'm build release candidates now.  So unless there is a further delay,
it is just too late for this release.
If the release is not closed yet, could I or you merge this safe update?

Thanks,
Vicente
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Emil Dotchevski-3
In reply to this post by Beman Dawes
On Thu, Jul 7, 2011 at 1:33 PM, Beman Dawes <[hidden email]> wrote:
> On Thu, Jul 7, 2011 at 1:03 PM, Emil Dotchevski
> <[hidden email]> wrote:
>
>> The fix is committed to trunk, I'm waiting for it to get through all
>> the tests and then I'll ask for permission to merge in the release
>> branch.
>
> OK, I'll hold the release waiting for that merge.

I'm requesting permission to merge.

A new test, "non_intrusive_exception_ptr_test" was introduced. The
results for a few of the platforms haven't yet been updated, however
I've tested mingw/gcc and msvc-10.0 myself, they're OK.

See http://tinyurl.com/5awaec.

Emil Dotchevski
Reverge Studios, Inc.
http://www.revergestudios.com/reblog/index.php?n=ReCode
_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Eric Niebler-3
On 7/8/2011 11:23 AM, Emil Dotchevski wrote:

> On Thu, Jul 7, 2011 at 1:33 PM, Beman Dawes <[hidden email]> wrote:
>> On Thu, Jul 7, 2011 at 1:03 PM, Emil Dotchevski
>> <[hidden email]> wrote:
>>
>>> The fix is committed to trunk, I'm waiting for it to get through all
>>> the tests and then I'll ask for permission to merge in the release
>>> branch.
>>
>> OK, I'll hold the release waiting for that merge.
>
> I'm requesting permission to merge.
>
> A new test, "non_intrusive_exception_ptr_test" was introduced. The
> results for a few of the platforms haven't yet been updated, however
> I've tested mingw/gcc and msvc-10.0 myself, they're OK.
>
> See http://tinyurl.com/5awaec.

Which changeset are you proposing to merge?

--
Eric Niebler
BoostPro Computing
http://www.boostpro.com
_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Emil Dotchevski-3
On Fri, Jul 8, 2011 at 12:59 PM, Eric Niebler <[hidden email]> wrote:

> On 7/8/2011 11:23 AM, Emil Dotchevski wrote:
>> On Thu, Jul 7, 2011 at 1:33 PM, Beman Dawes <[hidden email]> wrote:
>>> On Thu, Jul 7, 2011 at 1:03 PM, Emil Dotchevski
>>> <[hidden email]> wrote:
>>>
>>>> The fix is committed to trunk, I'm waiting for it to get through all
>>>> the tests and then I'll ask for permission to merge in the release
>>>> branch.
>>>
>>> OK, I'll hold the release waiting for that merge.
>>
>> I'm requesting permission to merge.
>>
>> A new test, "non_intrusive_exception_ptr_test" was introduced. The
>> results for a few of the platforms haven't yet been updated, however
>> I've tested mingw/gcc and msvc-10.0 myself, they're OK.
>>
>> See http://tinyurl.com/5awaec.
>
> Which changeset are you proposing to merge?

See my commit to trunk, revision 72924. That changeset is the only
difference in my code between trunk and release.

Emil Dotchevski
Reverge Studios, Inc.
http://www.revergestudios.com/reblog/index.php?n=ReCode
_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Beman Dawes
In reply to this post by Vicente Botet
On Fri, Jul 8, 2011 at 1:26 AM, Vicente Botet <[hidden email]> wrote:

>>>> I have committed https://svn.boost.org/trac/boost/changeset/72938 on
>>>> trunk a
>>>> simple patch. Can I commit after verification on trunk?
>>>
>>> Adding an extra set of superfluous parens makes the compiler happy?
>>> Really? That's whack. <shrug>
>>>
>>> Looks totally safe to me, but I don't know if Beman is in the packaging
>>> phase of the release yet. Beman?
>>
>> I'm build release candidates now.  So unless there is a further delay,
>> it is just too late for this release.
>>
>>
>
> If the release is not closed yet, could I or you merge this safe update?

The release is closed except by permission. Yes, please do merge
changeset 72938.

Just out of curiosity, why does the Intel compiler want the extra set
of parentheses?

--Beman
_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Vicente Botet
Beman Dawes wrote
On Fri, Jul 8, 2011 at 1:26 AM, Vicente Botet <[hidden email]> wrote: >>>> I have committed https://svn.boost.org/trac/boost/changeset/72938 on >>>> trunk a >>>> simple patch. Can I commit after verification on trunk? >>> >>> Adding an extra set of superfluous parens makes the compiler happy? >>> Really? That's whack. >>> >>> Looks totally safe to me, but I don't know if Beman is in the packaging >>> phase of the release yet. Beman? >> >> I'm build release candidates now.  So unless there is a further delay, >> it is just too late for this release. >> >> > > If the release is not closed yet, could I or you merge this safe update? The release is closed except by permission. Yes, please do merge changeset 72938. Just out of curiosity, why does the Intel compiler want the extra set of parentheses?
I have no idea why. Edward has requested to people from Intel but I don't have yet a response. I have tried to commit it, but I have no permission. svn ci duration.hpp -m "Merge Intel issue with default bool template initialization #72938" Sending duration.hpp Transmitting file data .svn: Commit failed (details follow): svn: Commit blocked by pre-commit hook (exit code 1) with output: U branches/release/boost/chrono/duration.hpp svn diff duration.hppIndex: duration.hpp =================================================================== --- duration.hpp (revision 72948) +++ duration.hpp (working copy) @@ -89,10 +89,10 @@ template <class Duration, class Rep2, bool = ( - (boost::is_convertible<typename Duration::rep, - typename common_type<typename Duration::rep, Rep2>::type>::value) - && (boost::is_convertible<Rep2, - typename common_type<typename Duration::rep, Rep2>::type>::value) + ((boost::is_convertible<typename Duration::rep, + typename common_type<typename Duration::rep, Rep2>::type>::value)) + && ((boost::is_convertible<Rep2, + typename common_type<typename Duration::rep, Rep2>::type>::value)) ) > struct duration_divide_imp @@ -119,10 +119,10 @@ template <class Rep, class Duration, bool = ( - (boost::is_convertible<typename Duration::rep, - typename common_type<typename Duration::rep, Rep>::type>::value) - && (boost::is_convertible<Rep, - typename common_type<typename Duration::rep, Rep>::type>::value) + ((boost::is_convertible<typename Duration::rep, + typename common_type<typename Duration::rep, Rep>::type>::value)) + && ((boost::is_convertible<Rep, + typename common_type<typename Duration::rep, Rep>::type>::value)) ) > struct duration_divide_imp2 Is this because I have not used the merge command? Best, Vicente
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Daniel James-3
On 9 July 2011 15:36, Vicente Botet <[hidden email]> wrote:
> I have tried to commit it, but I have no permission.

You need to include 'Authorized by Beman' in the commit message.
_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Vicente Botet
Daniel James-3 wrote
On 9 July 2011 15:36, Vicente Botet <[hidden email]> wrote:
> I have tried to commit it, but I have no permission.

You need to include 'Authorized by Beman' in the commit message.
Done.

svn ci duration.hpp -m "Merge Intel issue with default bool template initialization  #72938 - Authorized by Beman"
Sending        duration.hpp
Transmitting file data .
Committed revision 72984.

Thanks,
Vicente
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Beman Dawes
In reply to this post by Vicente Botet
On Sat, Jul 9, 2011 at 10:36 AM, Vicente Botet <[hidden email]> wrote:

> I have tried to commit it, but I have no permission.
>

At the end of the commit message, say "Authorized by Beman", but
without the quotes.

--Beman
_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Reply | Threaded
Open this post in threaded view
|

Re: [1.47.0] Any remaining showstoppers?

Eric Niebler-3
In reply to this post by Emil Dotchevski-3
On 7/8/2011 1:33 PM, Emil Dotchevski wrote:

> On Fri, Jul 8, 2011 at 12:59 PM, Eric Niebler <[hidden email]> wrote:
>> On 7/8/2011 11:23 AM, Emil Dotchevski wrote:
>>> On Thu, Jul 7, 2011 at 1:33 PM, Beman Dawes <[hidden email]> wrote:
>>>> On Thu, Jul 7, 2011 at 1:03 PM, Emil Dotchevski
>>>> <[hidden email]> wrote:
>>>>
>>>>> The fix is committed to trunk, I'm waiting for it to get through all
>>>>> the tests and then I'll ask for permission to merge in the release
>>>>> branch.
>>>>
>>>> OK, I'll hold the release waiting for that merge.
>>>
>>> I'm requesting permission to merge.
>>>
>>> A new test, "non_intrusive_exception_ptr_test" was introduced. The
>>> results for a few of the platforms haven't yet been updated, however
>>> I've tested mingw/gcc and msvc-10.0 myself, they're OK.
>>>
>>> See http://tinyurl.com/5awaec.
>>
>> Which changeset are you proposing to merge?
>
> See my commit to trunk, revision 72924. That changeset is the only
> difference in my code between trunk and release.

OK, please  go ahead. Be sure to include the string "Authorized by Eric"
in the commit msg.

Thanks,

--
Eric Niebler
BoostPro Computing
http://www.boostpro.com
_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
12